New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround MariaDB pretending to be MySQL #6844

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
4 participants
@zeha
Collaborator

zeha commented Aug 10, 2018

Short description

Avoids build failure after #6842 on Debian (uses MariaDB) and SLES 12 (also MariaDB).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Aug 10, 2018

Collaborator

Compile tested on Debian stretch (MariaDB 10.1.26) and MacOS (MySQL 8.0.12).

Collaborator

zeha commented Aug 10, 2018

Compile tested on Debian stretch (MariaDB 10.1.26) and MacOS (MySQL 8.0.12).

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie
Member

Habbie commented Aug 10, 2018

@zeha zeha requested a review from Habbie Aug 14, 2018

@Habbie

Habbie approved these changes Aug 14, 2018

@aerique aerique merged commit 0b537fb into PowerDNS:master Aug 14, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zeha zeha deleted the zeha:mariadb branch Aug 14, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 20, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 21, 2018

@pieterlexis pieterlexis referenced this pull request Aug 21, 2018

Merged

Authoritative server 4.1.4 backports #6866

4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment