Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added :excludeRange and :includeRange methods to DynBPFFilter class #6856

Merged
merged 3 commits into from Aug 17, 2018

Conversation

@skoef
Copy link
Contributor

@skoef skoef commented Aug 16, 2018

Short description

Wanting to move from DynBlockRulesGroup to DynBPFFilter, I found the excludeRange and includeRange methods missing, while the rest of the functionality between both ways of dynamically blocking was rather identical. So, I added them.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
skoef added 3 commits Aug 16, 2018
purgeExpired is a method of DynBPFFilter and not BPFFilter so it was
moved to the proper section in the document
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Aug 16, 2018
@rgacogne rgacogne self-requested a review Aug 16, 2018
Copy link
Member

@rgacogne rgacogne left a comment

LGTM, thanks!

@rgacogne rgacogne merged commit fcb311e into PowerDNS:master Aug 17, 2018
4 checks passed
4 checks passed
LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants