added :excludeRange and :includeRange methods to DynBPFFilter class #6856
Conversation
purgeExpired is a method of DynBPFFilter and not BPFFilter so it was moved to the proper section in the document
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
Wanting to move from
DynBlockRulesGroup
toDynBPFFilter
, I found theexcludeRange
andincludeRange
methods missing, while the rest of the functionality between both ways of dynamically blocking was rather identical. So, I added them.Checklist
I have: