New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SOA-check backoff on incoming NOTIFY and fix d_lock handling #6857

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
3 participants
@klaus3000

klaus3000 commented Aug 16, 2018

Short description

This pull request is a clean replacement of #6819 (rebase and merge conflicts)

  • Delete a zone from the list of failed slave-checks on incoming NOTIFY: If
    the master is not available, PDNS uses an incrmental backoff for SOA-checks to avoid
    constant SOA checks on the failed master server. If the master server comes back to life
    and sends a NOTIFY, the NOTIFY is ignored due to the backoff. This patch removes the zone
    from the list of failed slave-checks to allow immediate checking.

  • Debug-Log if a slave-check was skipped due to incremental backoff feature

  • Fix d_lock handling according to comments on #6819

  • Be more verbose about the consequences of a failed SOA check

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Klaus Darilion
Delete a zone from the list of failed slave-checks on incoming NOTIFY…
… and fix d_lock handling

- If the master is not available, PDNS uses an incrmental backoff for SOA-checks to avoid
constant SOA checks on the failed master server. If the master server comes back to life
and sends a NOTIFY, the NOTIFY is ignored due to the backoff. This patch removes the zone
from the list of failed slave-checks to allow immediate checking.

- Debug-Log if a slave-check was skipped due to incremental backoff feature

- Fix d_lock handling according to comments on #6819

- Be more verbose about the consequences of a failed SOA check

@klaus3000 klaus3000 referenced this pull request Aug 16, 2018

Closed

Remove SOA-check backoff on incoming NOTIFY #6819

4 of 7 tasks complete
@rgacogne

Looks good to me!

@pieterlexis

<3

@rgacogne rgacogne merged commit a059c42 into PowerDNS:master Aug 20, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 20, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 21, 2018

@pieterlexis pieterlexis referenced this pull request Aug 21, 2018

Merged

Authoritative server 4.1.4 backports #6866

4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment