Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge all auth/forward zone data including subtree. #6873

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@phonedph1
Copy link
Contributor

phonedph1 commented Aug 23, 2018

Short description

Per discussion on the mailing list removing forward-zones (or other data) would not purge the cache(s). This produces some surprises when you expect things to go back to normal. OTOH it would re-purge all existing data anyways, so just do both.

"Works for me" but might be doing something silly here.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Purge all auth/forward zone data including subtree.
Previously this would miss purging out removed entries/data.
@rgacogne
Copy link
Member

rgacogne left a comment

LGTM!

@pieterlexis pieterlexis merged commit 94744c2 into PowerDNS:master Aug 29, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pieterlexis pieterlexis added rec and removed auth labels Aug 29, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this pull request Aug 30, 2018

@pieterlexis pieterlexis referenced this pull request Aug 30, 2018

Merged

Recursor 4.1.4 backports #6867

4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.