Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Refactor trailing data tests #6897

Closed

Conversation

Projects
None yet
2 participants
@gibson042
Copy link
Contributor

commented Aug 29, 2018

Short description

Improve dnsdist regression testing:

  • DRY out TCP vs. UDP transport.
  • Verify that trailing data makes it to the backend.
  • Verify that TrailingDataRule() doesn't match queries without trailing data.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@gibson042 gibson042 referenced this pull request Sep 13, 2018

Merged

dnsdist: Expose trailing data #6967

6 of 7 tasks complete

@pieterlexis pieterlexis requested a review from rgacogne Sep 28, 2018

@rgacogne

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Superseded by #6967, unless I'm mistaken.

@rgacogne rgacogne closed this Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.