New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursor 4.1: Add pdnslog to Lua configuration scripts #6919

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
3 participants
@zeha
Collaborator

zeha commented Sep 3, 2018

Short description

In Debian I want to ship a default Lua config file, which will modify the default behaviour (rgd. root keys). As such I want to clearly note this in the startup log. Therefore, add pdnslog.

Targets 4.1. master is in #6848.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • NOT YET MERGED into master!
@rgacogne

This comment has been minimized.

Member

rgacogne commented Sep 3, 2018

I'm sure I'm missing something, but it looks like a duplicate of #6848 ?

@Habbie

This comment has been minimized.

Member

Habbie commented Sep 3, 2018

I'm sure I'm missing something, but it looks like a duplicate of #6848 ?

The L instead of g_log suggests this is filed against the wrong branch perhaps.

@zeha

This comment has been minimized.

Collaborator

zeha commented Sep 3, 2018

I forgot I already filed a PR for that!

@zeha zeha closed this Sep 3, 2018

@zeha zeha changed the base branch from master to rel/rec-4.1.x Sep 3, 2018

@zeha zeha reopened this Sep 3, 2018

@zeha zeha changed the title from recursor: Allow pdnslog to Lua configuration files to recursor 4.1: Add pdnslog to Lua configuration scripts Sep 3, 2018

@rgacogne rgacogne merged commit ffe493e into PowerDNS:rel/rec-4.1.x Sep 4, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment