New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Cleanup the netmask trees used for the ECS index on removals #6960

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Sep 12, 2018

Short description

Otherwise the intermediary nodes will remain and consume memory until the tree is deleted from the index, which might never happen if we still have active entries for this specific qname and qtype.

This is not a huge issue for IPv4 entries because there is a limited number of entries in the index, but it is much more painful with IPv6 entries.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rec: Cleanup the netmask trees used for the ECS index on removals
Otherwise the intermediary nodes will remain and consume memory
until the tree is deleted from the index, which might never happen
if we still have active entries for this specific qname and qtype.

@rgacogne rgacogne added this to the rec-4.2.0 milestone Sep 12, 2018

@rgacogne rgacogne merged commit 2a53110 into PowerDNS:master Sep 13, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec-ecs-index-tree-cleanup branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment