New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance query-logging with timing for MySQL, PostgreSQL and SQLite #6975

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@ahupowerdns
Copy link
Member

ahupowerdns commented Sep 15, 2018

Short description

Add timing information when we run with query-logging. Turns one line into three. Lines are adorned with the value of 'this' so the three lines can be correlated even under load. Logs time spent for the 'execute' part and time spent until the last row is processed. This PR was inspired by a debugging session to find a performance problem with a customer, where this output would have been tremendously useful.

No timing calls are made unless query logging is enabled.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the auth-4.2.0 milestone Sep 25, 2018

@pieterlexis pieterlexis merged commit 2d2d5ff into PowerDNS:master Sep 28, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment