New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec-4.1.x: Authority records in AA=1 CNAME answer are authoritative #6980

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Sep 19, 2018

Short description

The records other than the CNAME for the initial target in ANSWER are not, nor are the ADDITIONAL ones, but AUTHORITY records are.

(cherry picked from commit cdc5d0c)

Backport of #6979 to rel/rec-4.1.x.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
rec: Authority records in AA=1 CNAME answer are authoritative
The records other than the CNAME for the initial target in ANSWER
are not, nor are the ADDITIONAL ones, but authority records are.

(cherry picked from commit cdc5d0c)

@rgacogne rgacogne added this to the rec-4.1.x milestone Sep 19, 2018

@rgacogne rgacogne merged commit 7a17841 into PowerDNS:rel/rec-4.1.x Oct 8, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No alert changes
Details
LGTM analysis: Python No alert changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec41-cname-authority branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment