New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add warning rates to dynBlockRulesGroup rules #6986

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Sep 25, 2018

Short description

After thinking a bit more about the needs described in #6907, I could not find a meaningful scenario where we want different actions for different rates except for the warning case. So for now I took the easy route of just adding a warning threshold, and we can improve on it later if we find that we need more than that.
Closes #6907.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Sep 25, 2018

@rgacogne rgacogne requested a review from chbruyand Oct 2, 2018

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-warning-dynblocks branch from d9bd2e5 to 1d3ba13 Oct 3, 2018

@chbruyand

LGTM!
It may be nice to add a test where only the warning threshold is enabled.

@rgacogne

This comment has been minimized.

Member

rgacogne commented Oct 11, 2018

It may be nice to add a test where only the warning threshold is enabled.

This is actually not handled, since you can do that by using the regular threshold and a NoOp action, instead of using the warning threshold. Do you think it would make sense to handle that? We could make it work by passing a 0 value to the regular rate, but I'm not sure it would be very intuitive..

@chbruyand

👍

@rgacogne rgacogne merged commit bd0331e into PowerDNS:master Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-warning-dynblocks branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment