dnsdist: Release memory on DNS over TLS handshake failure#7060
Merged
rgacogne merged 3 commits intoPowerDNS:masterfrom Oct 15, 2018
Merged
dnsdist: Release memory on DNS over TLS handshake failure#7060rgacogne merged 3 commits intoPowerDNS:masterfrom
rgacogne merged 3 commits intoPowerDNS:masterfrom
Conversation
Member
Author
|
We should really use smart pointers there, although |
7 tasks
zeha
reviewed
Oct 12, 2018
pdns/dnsdistdist/tcpiohandler.cc
Outdated
| try { | ||
| handleIORequest(res, timeout); | ||
| } | ||
| catch(const std::exception&) { |
Collaborator
There was a problem hiding this comment.
maybe this should catch (...) instead, to also get PDNSExceptions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Otherwise we leak the memory allocated to handle the
TLSconnection if the handshake doesn't succeed correctly.Checklist
I have: