dnsdist: Add a setting to control the number of stored sessions #7062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chbruyand
reviewed
Oct 15, 2018
pdns/dnsdist-lua.cc
Outdated
| @@ -1541,6 +1541,10 @@ void setupLuaConfig(bool client) | |||
| if (vars->count("sessionTickets")) { | |||
| frontend->d_enableTickets = boost::get<bool>((*vars)["sessionTickets"]); | |||
| } | |||
|
|
|||
| if (vars->count("numberOfStoredSessions")) { | |||
| frontend->d_maxStoredSessions = boost::get<int>((*vars)["numberOfStoredSessions"]); | |||
There was a problem hiding this comment.
Maybe check for negative values and issue a warning ?
rgacogne
force-pushed
the
dnsdist-tls-stored-sessions
branch
from
2cec26e
to
aa4f798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Short description
This allows setting a larger or smaller stored sessions cache, or even disabling it entirely. Note that we currently only supports stored sessions when the
OpenSSLprovider is used, asGnuTLSrequires writing a custom cache and so far we did not care enough to implement it.Checklist
I have: