Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add a setting to control the number of stored sessions #7062

Merged
merged 2 commits into from Oct 16, 2018

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 12, 2018

Short description

This allows setting a larger or smaller stored sessions cache, or even disabling it entirely. Note that we currently only supports stored sessions when the OpenSSL provider is used, as GnuTLS requires writing a custom cache and so far we did not care enough to implement it.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Oct 12, 2018
@rgacogne rgacogne requested a review from pieterlexis Oct 12, 2018
Copy link
Member

@chbruyand chbruyand left a comment

LGTM

@@ -1541,6 +1541,10 @@ void setupLuaConfig(bool client)
if (vars->count("sessionTickets")) {
frontend->d_enableTickets = boost::get<bool>((*vars)["sessionTickets"]);
}

if (vars->count("numberOfStoredSessions")) {
frontend->d_maxStoredSessions = boost::get<int>((*vars)["numberOfStoredSessions"]);

This comment has been minimized.

@chbruyand

chbruyand Oct 15, 2018
Member

Maybe check for negative values and issue a warning ?

rgacogne added 2 commits Oct 12, 2018
@rgacogne rgacogne force-pushed the rgacogne:dnsdist-tls-stored-sessions branch from 2cec26e to aa4f798 Oct 15, 2018
@rgacogne rgacogne merged commit d774c32 into PowerDNS:master Oct 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-tls-stored-sessions branch Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.