New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec-4.1.x: avoid a memory leak in catch-all exception handler #7073

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Oct 17, 2018

Short description

This commit prevents a leak of DNSComboWriter in the catch-all exception
handler, which could be triggered by an ImmediateServFailException while invoking followCNAMERecords, getFakeAAAARecords or getFakePTRRecords from a Lua hook.

(cherry picked from commit cbb097d)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
pdns-recursor: avoid a memory leak in catch-all exception handler
This commit prevents a leak of DNSComboWriter in the catch-all exception
handler.

(cherry picked from commit cbb097d)

@rgacogne rgacogne added this to the rec-4.1.x milestone Oct 17, 2018

@rgacogne rgacogne changed the title from pdns-recursor: avoid a memory leak in catch-all exception handler to rec-4.1.x: avoid a memory leak in catch-all exception handler Oct 17, 2018

@rgacogne rgacogne requested a review from chbruyand Oct 17, 2018

@rgacogne rgacogne merged commit 6e23e91 into PowerDNS:rel/rec-4.1.x Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec41-backport-7070 branch Oct 17, 2018

@rgacogne

This comment has been minimized.

Member

rgacogne commented Oct 31, 2018

For the record, this PR is a backport of #7070.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment