Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Allow NoRecurse for use in dynamic blocks or lua rules #7087

Merged
merged 1 commit into from Nov 20, 2018

Conversation

phonedph1
Copy link
Contributor

Short description

We can do NoRecurseAction() but not similar actions within a Lua rule nor as a dynamic block action.

This is potentially silly, please just close if it doesn't make sense to be doing - notably it's somewhat confusing because the query is put into the query ring before actions so it makes things like grepq look a bit weird.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks sane, but I'm not sure how much it makes sense to set RD=0 as a dynblock action? I'm guessing this is to minimize the impact in case of a false positive, so the client still gets an answer as long as it's already in the recursor's cache, but I'm afraid this would still hurt the recursor in case of a real attack. I guess it's doesn't really hurt to have the option, though.

@rgacogne
Copy link
Member

PR is now conflicted, though :-/

@phonedph1
Copy link
Contributor Author

Yeah I am not sure it makes much sense, and was considering just closing this. I think a separate PR to set rd=0 as part of the lua actions will still make sense though.

@pieterlexis pieterlexis merged commit 49023c1 into PowerDNS:master Nov 20, 2018
@phonedph1 phonedph1 deleted the dynpool branch August 23, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants