New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add HELP and TYPE for dnsdist_server_ stats #7089

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@pieterlexis
Member

pieterlexis commented Oct 22, 2018

Short description

These were missing from the output. I've put them above the for loop. According to the Open Metrics standard, metrics don't have to be directly underneath the HELP or TYPE (and only one for each metric is allowed).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis requested a review from rgacogne Oct 22, 2018

@rgacogne rgacogne added the dnsdist label Oct 23, 2018

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Oct 23, 2018

@rgacogne rgacogne merged commit 7f67952 into PowerDNS:master Oct 23, 2018

@pieterlexis pieterlexis deleted the pieterlexis:dnsdist-stats-add-help branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment