Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Fix return-type detection with boost 1.69's tribool #7092

Merged
merged 1 commit into from Oct 23, 2018
Merged

dnsdist: Fix return-type detection with boost 1.69's tribool #7092

merged 1 commit into from Oct 23, 2018

Conversation

rgacogne
Copy link
Member

Short description

Hopefully fixes #7091, although I did not test against the development version of Boost.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Oct 23, 2018
pieterlexis
pieterlexis approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@pieterlexis pieterlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build-issue on boost 1.69 indeed

@rgacogne rgacogne merged commit af8ef49 into PowerDNS:master Oct 23, 2018
@rgacogne rgacogne deleted the dnsdist-tribool-fix branch October 23, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieterlexis pieterlexis pieterlexis approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.3.x
Development

Successfully merging this pull request may close these issues.

dnsdist: Fails to build with Boost 1.69 (develop snapshot)
2 participants
@rgacogne @pieterlexis