Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add security polling #7115

Merged
merged 3 commits into from Oct 31, 2018
Merged

Conversation

rgacogne
Copy link
Member

Short description

Add the same security polling mechanism than the authoritative server and the recursor already have.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Contributor

@ahupowerdns ahupowerdns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, and I appreciate moving the common functionality to misc.cc.

Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pdns/dnsdistdist/dnsdist-secpoll.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit ed66a48 into PowerDNS:master Oct 31, 2018
@rgacogne rgacogne deleted the dnsdist-secpoll branch October 31, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants