New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: allow the signture inception to be off by a number of seconds. #7125

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@mind04
Contributor

mind04 commented Oct 31, 2018

Short description

backport #7081

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the rec-4.1.x milestone Oct 31, 2018

@Habbie

Habbie approved these changes Nov 1, 2018 edited

Approved if the default is changed to 0.

- Integer
- Default: 60
Allow the signture inception to be off by this number of seconds. Negative values are not allowed.

This comment has been minimized.

@Habbie

Habbie Nov 1, 2018

Member

signature -> signature

maybe: off -> early

This comment has been minimized.

@hlindqvist

hlindqvist Nov 1, 2018

Contributor

I think that something like "in the future" would be more clear than "early" (which at least seems confusing to me, but that could be a matter of perspective).

@Habbie Habbie merged commit a263a86 into PowerDNS:rel/rec-4.1.x Nov 1, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mind04 mind04 deleted the mind04:inception-skew branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment