Add a PoolAvailableRule to easily add backup pools #7140
Merged
Conversation
Still need to add tests and documentation, will work on that now. |
I've added documentation and did some basic testing using this to check correct behavior in case of up:
And this to see if it works properly when a pool is down:
|
Nice! I like it! |
LGTM! |
Yes! It looks great! :) I think I can test it. |
Hello! I tested it in following configuration:
Then I manually disabled all three servers in default pool:
And all requests were redirected to backup one:
Then I returned one of the servers to active status and it worked well tool:
|
I closed my PR about "backup pool for pool". This PR implement it much better way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Short description
This adds the PoolAvailableRule. Can be used to apply different pools based on availability.
Checklist
I have: