Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix warnings, mostly unused parameters, reported by -Wextra #7168

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@rgacogne
Copy link
Member

commented Nov 8, 2018

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added the dnsdist label Nov 8, 2018

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Nov 8, 2018

@rgacogne

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

Note that since std::thread::thread() accepts any Callable, we should just change the return type of our thread functions to void instead of void *.

@pieterlexis pieterlexis merged commit 4299738 into PowerDNS:master Nov 14, 2018

4 checks passed

LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-fix-extra-warns branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.