New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Skip NS records in authority/additional sections of NXD / NODATA #7258

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Dec 4, 2018

Short description

These records are quite susceptible to fragmentation poisoning.
Based on a suggestion by Tsunehiko Suzuki (thanks!).

Note that Unbound introduced the same change in 1.8.2:

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added some commits Dec 4, 2018

rec: Skip NS records in authority/additional sections of NXD / NODATA
These records are quite susceptible to fragmentation poisoning.
Based on a suggestion by Tsunehiko Suzuki (thanks!).

Note that Unbound introduced the same change in 1.8.2:
- NLnetLabs/unbound@f7e9913
- NLnetLabs/unbound@7458729

@rgacogne rgacogne added this to the rec-4.2.0 milestone Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment