Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Check that SO_ATTACH_BPF is defined before enabling eBPF #7267

Merged
merged 1 commit into from Dec 7, 2018

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Dec 6, 2018

Short description

It turns out that RH decided to backport only the tracing subsystem part of eBPF as a "Technology Preview" in the RHEL / Centos 7.6 kernel, so most of the eBPF stuff is present but not what is needed
to use the networking parts.

With this change, eBPF support is disabled when SO_ATTACH_BPF is missing since we can't attach our filter to a socket without that anyway. Tested on CentOS 7.6 and Arch.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
It turns out that RH decided to backport only the tracing subsystem
part of eBPF as a "Technology Preview" in the RHEL / Centos 7.6
kernel, so most of the eBPF stuff is present but not what is needed
to use the networking parts.
@Habbie
Copy link
Member

@Habbie Habbie commented Dec 6, 2018

This builds on el7, and dnsdist --version is unchanged from before (no ebpf on either side).

@Habbie
Copy link
Member

@Habbie Habbie commented Dec 6, 2018

Debian stretch: no --version changes with/without this PR.

@Habbie
Habbie approved these changes Dec 6, 2018
@rgacogne rgacogne merged commit 85a1c1a into PowerDNS:master Dec 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-ebpf-centos76 branch Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants