Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add a 'rise' parameter to 'newServer()' #7322

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
2 participants
@rgacogne
Copy link
Member

commented Jan 3, 2019

Short description

In some setups it might make sense to wait until 2 or 3 checks have succeeded before starting to use a backend, because we care about stability more than we want the backend to get back up fast.
This PR adds a new optional rise parameter to newServer(), specifying how many health checks must be successful before the backend is marked as up.

Closes #7237.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Jan 3, 2019

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-server-rise branch from b98e7a8 to 1b633be Jan 10, 2019

@pieterlexis pieterlexis merged commit 40497c8 into PowerDNS:master Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-server-rise branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.