New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec-4.1.x: Try another worker before failing if the first pipe was full #7377

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
2 participants
@rgacogne
Copy link
Member

rgacogne commented Jan 16, 2019

Short description

When the recursor is configured to distribute incoming queries to its worker threads itself, and in the unlikely case that the pipe to the selected thread is full, randomly select another worker to handle the query. If this one fails too, we give up.

Same PR than #7383 but for rel/rec-4.1.x.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the rec-4.1.x milestone Jan 16, 2019

@rgacogne rgacogne requested review from chbruyand and pieterlexis Jan 16, 2019

@chbruyand
Copy link
Member

chbruyand left a comment

LGTM!

@rgacogne rgacogne merged commit 5a1c699 into PowerDNS:rel/rec-4.1.x Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec41-retry-on-full-pipe branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment