New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec-4.1.x: Fix compilation in handleRunningTCPQuestion without protobuf support #7403

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@rgacogne
Copy link
Member

rgacogne commented Jan 21, 2019

Short description

6c4d0ab introduced a call to the Lua ipfilter hook that required access to the DNS header, but the corresponding variable was only declared when protobuf support had been enabled.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the rec-4.1.x milestone Jan 21, 2019

@rgacogne rgacogne changed the title rec: Fix compilation in handleRunningTCPQuestion without protobuf support rec-4.1.x: Fix compilation in handleRunningTCPQuestion without protobuf support Jan 21, 2019

@omoerbeek
Copy link
Contributor

omoerbeek left a comment

I ran into this doing the OpenBSD port as well and came up with the same diff independently.

@rgacogne rgacogne merged commit 4dcb055 into PowerDNS:rel/rec-4.1.x Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec41-dh-no-protobuf branch Jan 22, 2019

@aerique aerique modified the milestones: rec-4.1.x, rec-4.1.10 Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment