Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix off-by-one in mvRule counting #7426

merged 1 commit into from Jan 28, 2019


Copy link

@Habbie Habbie commented Jan 27, 2019

Short description

This makes mvRule(0,x) work where x is the highest rule number.

Maybe we want a test for this?


I have:

  • read the document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

this makes mvRule(0,x) work where x is the highest rule number
@rgacogne rgacogne merged commit b336f1e into PowerDNS:master Jan 28, 2019
@Habbie Habbie deleted the mvrule-off-by-one branch February 7, 2019 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants