Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix off-by-one in mvRule counting #7426

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@Habbie
Copy link
Member

commented Jan 27, 2019

Short description

This makes mvRule(0,x) work where x is the highest rule number.

Maybe we want a test for this?

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
fix off-by-one in mvRule counting
this makes mvRule(0,x) work where x is the highest rule number

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Jan 28, 2019

@rgacogne rgacogne merged commit b336f1e into PowerDNS:master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Habbie Habbie deleted the Habbie:mvrule-off-by-one branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.