New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec-4.1.x: Add an option to export only responses over protobuf #7434

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@rgacogne
Copy link
Member

rgacogne commented Jan 30, 2019

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the rec-4.1.x milestone Jan 30, 2019

@rgacogne rgacogne changed the title rec: Add an option to export only responses over protobuf rec-4.1.x: Add an option to export only responses over protobuf Jan 30, 2019

@pieterlexis
Copy link
Member

pieterlexis left a comment

lgtm, when adding these docs to master, a few words on how onlyResponses=true and onlyTagged=true work together might be nice


.. versionchanged:: 4.1.11

The optional ``responsesOnly`` parameter was added.

This comment has been minimized.

@pieterlexis

pieterlexis Jan 30, 2019

Member

this change will have to go into master

This comment has been minimized.

@rgacogne

rgacogne Jan 30, 2019

Author Member

We already have more options, including this one, in master since #6698

This comment has been minimized.

@pieterlexis

pieterlexis Jan 30, 2019

Member

this doc-change is not in master, and we publish the docs from master only. I should have been a bit more clear :)

This comment has been minimized.

@rgacogne

rgacogne Jan 30, 2019

Author Member

Oh right, sorry! 👍

This comment has been minimized.

@aerique

aerique Jan 31, 2019

Member

I'm not seeing the doc change in master. Wanted to make a PR but the protobufServer definition is just protobufServer(servers [, options])) now.

This comment has been minimized.

@Habbie

Habbie Jan 31, 2019

Member

The master docs (recursordist/docs/lua-config/protobuf.rst) have [, options] as 'new in 4.2.0' and protobufServer(server[[[[[[[, timeout=2], maxQueuedEntries=100], reconnectWaitTime=1], maskV4=32], maskV6=128], asyncConnect=false], taggedOnly=false]) as 'deprecated in 4.2.0' - in other words, that's the 4.1.x version, and that's the one that got a new optional argument responsesOnly, at line 35 of protobuf.rst.

This comment has been minimized.

@aerique

aerique Feb 1, 2019

Member

Yes, but it's not clear to me if something still needs to be added to the docs in master as Pieter said above.

This comment has been minimized.

@rgacogne

rgacogne Feb 1, 2019

Author Member

The new option needs to be added to the 'deprecated' 4.1.x version of the docs in master, exactly at the place pointed out by Habbies, yes.

@rgacogne rgacogne merged commit 5a5d87c into PowerDNS:rel/rec-4.1.x Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:rec41-protobuf-responses-only branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment