Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report checkKey errors upwards in makeFromISCFile exception #7516

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@Habbie
Copy link
Member

Habbie commented Feb 24, 2019

Short description

Before: Error: Invalid DNS Private Key in file 'zsk-private_file.txt

After: Error: Invalid DNS Private Key in file 'zsk-private_file.txt' (n does not equal p q)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added this to the auth-4.2.0 milestone Feb 24, 2019

Show resolved Hide resolved pdns/dnssecinfra.cc Outdated

@Habbie Habbie force-pushed the Habbie:fromiscfile-errors branch from 10989c2 to be135ee Feb 28, 2019

@Habbie Habbie requested a review from rgacogne Feb 28, 2019

@rgacogne rgacogne merged commit b0f70f2 into PowerDNS:master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.