Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSNameSet and QNameSetRule #7537

Merged
merged 5 commits into from Mar 5, 2019
Merged

DNSNameSet and QNameSetRule #7537

merged 5 commits into from Mar 5, 2019

Conversation

@andreydomas
Copy link
Contributor

@andreydomas andreydomas commented Mar 1, 2019

Short description

Set of DNSName based on std::set.
Query rule for test if set contains qname.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
Copy link
Member

@rgacogne rgacogne left a comment

Thank you for this PR! Code looks good at a quick glance, a few comments but nothing that would prevent merging.

pdns/dnsdist-lua-bindings.cc Outdated Show resolved Hide resolved
pdns/dnsdistdist/dnsdist-rules.hh Outdated Show resolved Hide resolved
pdns/dnsdistdist/docs/rules-actions.rst Outdated Show resolved Hide resolved
pdns/dnsname.hh Outdated Show resolved Hide resolved
@andreydomas andreydomas marked this pull request as ready for review Mar 4, 2019
@andreydomas andreydomas closed this Mar 4, 2019
@andreydomas andreydomas reopened this Mar 4, 2019
pdns/dnsdistdist/docs/reference/dnsnameset.rst Outdated Show resolved Hide resolved
pdns/dnsdistdist/docs/rules-actions.rst Outdated Show resolved Hide resolved
@andreydomas andreydomas closed this Mar 4, 2019
@andreydomas andreydomas reopened this Mar 4, 2019
@rgacogne rgacogne merged commit 9fa4d40 into PowerDNS:master Mar 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants