Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Prevent 0-TTL cache hits #7585

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

rgacogne
Copy link
Member

Short description

Fixes #7534.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Since we no longer use cached answers when the TTL drops to 0,
we need a bit more of margin.
@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Mar 15, 2019
@rgacogne rgacogne merged commit 3b3dbac into PowerDNS:master Apr 4, 2019
@rgacogne rgacogne deleted the dnsdist-zero-ttl branch April 4, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist cache can send out ttl=0 answers, confusing some clients
1 participant