Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Prevent 0-TTL cache hits #7585

Merged
merged 2 commits into from Apr 4, 2019

Conversation

Projects
None yet
1 participant
@rgacogne
Copy link
Member

commented Mar 15, 2019

Short description

Fixes #7534.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne added some commits Mar 14, 2019

dnsdist: Increase the base TTL to 2 as 1 might expire too soon
Since we no longer use cached answers when the TTL drops to 0,
we need a bit more of margin.

@rgacogne rgacogne added the dnsdist label Mar 15, 2019

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Mar 15, 2019

@rgacogne rgacogne requested a review from pieterlexis Mar 19, 2019

@rgacogne rgacogne merged commit 3b3dbac into PowerDNS:master Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-zero-ttl branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.