Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Rec ecs cache limit with tt (7631) #7651

merged 14 commits into from Apr 2, 2019


None yet
4 participants
Copy link

omoerbeek commented Apr 1, 2019

Short description

Backport of #7631

Watchout! Untested! Syncres unit test does not work since is needs some extra functionality that I did not backport yet.

Additionally, code is not merged yet to master.


I have:

  • read the document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

ahupowerdns and others added some commits Mar 12, 2019

implement a configurable ECS cache limit, defaulting to /24 and /56 o…
…f IPv6. So a /25 response will not get cached.

(cherry picked from commit 1dab554)
(cherry picked from commit fd8898f)
rec: Document 'ecs-ipv4-cache-bits' and 'ecs-ipv6-cache-bits'
(cherry picked from commit 4d8c05d)
(cherry picked from commit 216dc60)
rec: Set ecs-ipv4-cache-bits and ecs-ipv6-cache-bits in the tests
(cherry picked from commit 0cd27a3)
(cherry picked from commit 30974ec)
Initial code for ecs-cache-limit-ttl.
(cherry picked from commit ed9019c)
Add tests for ecs-cache-limit-ttl
(cherry picked from commit 2cbe6a4)
New approach. I spelled out the logic to make it more clear.
Points to keep in mind: > vs >=
What do we do if s_ecscachelimitttl is not set? I chose to let the scope determine

(cherry picked from commit e7861cc)
Show resolved Hide resolved pdns/ Outdated

This comment has been minimized.

Copy link

ahupowerdns commented Apr 2, 2019

Looks good to me, thorough work on on a complicated feature.

Show resolved Hide resolved pdns/syncres.hh Outdated

@aerique aerique added this to the rec-4.1.x milestone Apr 2, 2019

@omoerbeek omoerbeek merged commit 8703bd7 into PowerDNS:rel/rec-4.1.x Apr 2, 2019

0 of 2 checks passed

ci/circleci: Build Error Your tests failed on CircleCI
continuous-integration/travis-ci/pr The Travis CI build is in progress

@omoerbeek omoerbeek deleted the omoerbeek:backport-7631 branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.