Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Move constants to proper namespace #7678

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
2 participants
@Habbie
Copy link
Member

commented Apr 5, 2019

Short description

Redo of #5669. Separate PR because the rebase involved some manual work (some code got removed, moved around, etc. since), and this way we can compare the two PRs to make sure I did not miss anything.

TODO: add the deprecation warnings as discussed in #5669. Pushed.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Apr 8, 2019

@pieterlexis pieterlexis referenced this pull request Apr 8, 2019

Closed

dnsdist: Move constants to proper namespace. #5669

4 of 6 tasks complete
@Habbie

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

This is waiting for #7685, and I'd like to shuffle the commits around so that they prove that the -old- tests still pass under the -new- namespace setup.

@rgacogne

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

#7685 has been merged, but no pressure ;-)

@Habbie Habbie force-pushed the Habbie:dnsdist-mv-constants2 branch from 170ecf6 to 8b4bec3 Apr 10, 2019

@Habbie Habbie force-pushed the Habbie:dnsdist-mv-constants2 branch from 8b4bec3 to 09b45aa Apr 10, 2019

@Habbie

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

This is waiting for #7685, and I'd like to shuffle the commits around so that they prove that the -old- tests still pass under the -new- namespace setup.

I have now run the old tests under the new namespaces, and as long as I tolerate the deprecation warnings during startup in the test suite, all tests pass.

Ready for review, merge.

@rgacogne rgacogne merged commit 6acb120 into PowerDNS:master Apr 11, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.