Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: exit when setting ciphers fails (GNUTLS) #7718

Merged
merged 1 commit into from
Apr 12, 2019
Merged

dnsdist: exit when setting ciphers fails (GNUTLS) #7718

merged 1 commit into from
Apr 12, 2019

Conversation

pieterlexis
Copy link
Contributor

Short description

Before, we would log the fact that we could not set the ciphers for
gnutls but still start. When a connection came in, dnsdist would crash.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis
dnsdist: exit when setting ciphers fails (GNUTLS)
d26d684 
Before, we would log the fact that we could not set the ciphers for
gnutls but still start. When a connection came in, dnsdist would crash.
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Apr 11, 2019
@rgacogne rgacogne merged commit 8bd3eb5 into PowerDNS:master Apr 12, 2019
@pieterlexis pieterlexis deleted the dnsdist-dont-crash-gnutls-wrong-ciphers branch April 12, 2019 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlexis @rgacogne