Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: exit when setting ciphers fails (GNUTLS) #7718

Merged

Conversation

Projects
None yet
2 participants
@pieterlexis
Copy link
Member

commented Apr 11, 2019

Short description

Before, we would log the fact that we could not set the ciphers for
gnutls but still start. When a connection came in, dnsdist would crash.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
dnsdist: exit when setting ciphers fails (GNUTLS)
Before, we would log the fact that we could not set the ciphers for
gnutls but still start. When a connection came in, dnsdist would crash.

@pieterlexis pieterlexis requested a review from rgacogne Apr 11, 2019

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Apr 11, 2019

@rgacogne rgacogne merged commit 8bd3eb5 into PowerDNS:master Apr 12, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci: build Your tests passed on CircleCI!
Details

@pieterlexis pieterlexis deleted the pieterlexis:dnsdist-dont-crash-gnutls-wrong-ciphers branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.