Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Don't let 'self' dangling while parsing the request's qname #7814

Merged
merged 2 commits into from
May 13, 2019
Merged

dnsdist: Don't let 'self' dangling while parsing the request's qname #7814

merged 2 commits into from
May 13, 2019

Conversation

rgacogne
Copy link
Member

Short description

Otherwise we might try to read an uninitialized value in the destructor if the parsing fails.
Hopefully fixes #7810.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone May 13, 2019
@rgacogne rgacogne merged commit 9b8a3ae into PowerDNS:master May 13, 2019
@rgacogne rgacogne deleted the dnsdist-doh-self-dangling branch May 13, 2019 12:25
@rgacogne rgacogne mentioned this pull request May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.4.0
Development

Successfully merging this pull request may close these issues.

dnsdist segfault (DoH)
1 participant
@rgacogne