Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNMP: Use net-snmp-config --netsnmp-agent-libs instead of --agent-libs #7818

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
2 participants
@rgacogne
Copy link
Member

commented May 13, 2019

Short description

As discussed in #7762, this seems to keep the environment cleaner.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@zeha

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

Results on buster:

Previously:

dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libnetsnmpmibs.so.30 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libpci.so.3 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libdl.so.2 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libatomic.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libsensors.so.5 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libwrap.so.0 (it uses none of the library's symbols)

Now:

dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libatomic.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/dnsdist/usr/bin/dnsdist was not linked against libnetsnmpmibs.so.30 (it uses none of the library's symbols)

Also tried with pdns-recursor, enabling --with-net-snmp now gives:

dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/pdns-recursor/usr/sbin/pdns_recursor was not linked against libnetsnmpmibs.so.30 (it uses none of the library's symbols)
@zeha

zeha approved these changes May 14, 2019

@rgacogne rgacogne merged commit fc353c1 into PowerDNS:master May 15, 2019

17 of 18 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build-auth Your tests passed on CircleCI!
Details
ci/circleci: build-recursor Your tests passed on CircleCI!
Details
ci/circleci: test-auth-algorithms Your tests passed on CircleCI!
Details
ci/circleci: test-auth-api Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-bind Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gmysql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gpgsql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gsqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-ldap Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-lmdb Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-mydns Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-mssql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-sqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-tinydns Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-api Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-bulk Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-regression Your tests passed on CircleCI!
Details

@rgacogne rgacogne deleted the rgacogne:netsnmp-agent-libs branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.