Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove second, incomplete copy of Lua EDNSOptionCode table #7833

Merged

Conversation

@Habbie
Copy link
Member

@Habbie Habbie commented May 18, 2019

Short description

The second incomplete copy was the one being used in practice, making EDNSOptionCode.KEYTAG invisible because it only existed in the first copy of the table.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
@Habbie Habbie added this to the dnsdist-1.4.0 milestone May 18, 2019
@rgacogne rgacogne merged commit 78e799a into PowerDNS:master May 20, 2019
18 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants