Skip to content

dnsdist: disallow TCP disablement #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2019
Merged

dnsdist: disallow TCP disablement #7860

merged 1 commit into from
Jun 14, 2019

Conversation

@pieterlexis
Copy link
Contributor

@pieterlexis pieterlexis commented May 28, 2019

Short description

As not doing DNS over TCP is just dumb :). Docs say 1.4.0, but we could skip till 1.5.0.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis requested a review from rgacogne May 28, 2019 13:02
Habbie
Habbie reviewed May 28, 2019
View reviewed changes
rgacogne
rgacogne approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@pieterlexis pieterlexis force-pushed the dnsdist-rm-disable-tcp branch from 4723aa1 to 0230e35 Compare May 29, 2019 13:34
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jun 6, 2019
@rgacogne rgacogne merged commit 195c733 into PowerDNS:master Jun 14, 2019
@pieterlexis pieterlexis deleted the dnsdist-rm-disable-tcp branch June 14, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Habbie Habbie Habbie left review comments

@rgacogne rgacogne rgacogne approved these changes

Assignees

No one assigned

Labels

dnsdist enhancement

Projects

None yet

Milestone

dnsdist-1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pieterlexis @Habbie @rgacogne