Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: disallow TCP disablement #7860

Merged
merged 1 commit into from Jun 14, 2019

Conversation

pieterlexis
Copy link
Contributor

Short description

As not doing DNS over TCP is just dumb :). Docs say 1.4.0, but we could skip till 1.5.0.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jun 6, 2019
@rgacogne rgacogne merged commit 195c733 into PowerDNS:master Jun 14, 2019
@pieterlexis pieterlexis deleted the dnsdist-rm-disable-tcp branch June 14, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants