Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuffixMatchTree: Fix root removal, partial match of non-leaf nodes #7886

Merged
merged 3 commits into from
Jun 17, 2019

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 7, 2019

Short description

If we insert fr and www.domain.fr, domain.fr should not match www.domain.fr, the leaf node, and it should not match the intermediary domain.fr node, but it should match the fr end-node.
It should also be possible to remove the root from the tree.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

If we insert fr and www.domain.fr, domain.fr should not match
www.domain.fr, the leaf node, and it should not match the
intermediary domain.fr node, but it should match the fr
end-node.
@rgacogne rgacogne merged commit 92cf991 into PowerDNS:master Jun 17, 2019
@rgacogne rgacogne deleted the smt-fixes branch June 17, 2019 08:19
@omoerbeek omoerbeek modified the milestones: rec-4.2.0, rec-4.2.0-rc2 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants