Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth API, pdnsutil: improve backend transaction correctness #7891

Merged
merged 2 commits into from Jun 9, 2019

Conversation

@Habbie
Copy link
Member

commented Jun 7, 2019

Short description

We do deletes+inserts outside of transactions. This makes it possible to briefly observe NXDOMAIN while replacing RRsets. With this PR, most operations are correctly wrapped in transactions.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie Habbie added auth defect labels Jun 7, 2019

@Habbie Habbie added this to the auth-4.2.0-rc2 milestone Jun 7, 2019

@Habbie

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

I asked on IRC 'is there a reason that ws-auth.cc apiZoneMetadataKind uses B instead of di.backend?'. The answer arrived just after I PRed this: metadata can live in a different backend than the zone itself. This will need some work.

@Habbie

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

I asked on IRC 'is there a reason that ws-auth.cc apiZoneMetadataKind uses B instead of di.backend?'. The answer arrived just after I PRed this: metadata can live in a different backend than the zone itself. This will need some work.

Pushed.

@zeha

zeha approved these changes Jun 7, 2019

@Habbie Habbie force-pushed the Habbie:gsql-transactions branch from 289141e to f43646f Jun 7, 2019

@Habbie Habbie merged commit e3db236 into PowerDNS:master Jun 9, 2019

18 checks passed

ci/circleci: build-auth Your tests passed on CircleCI!
Details
ci/circleci: build-recursor Your tests passed on CircleCI!
Details
ci/circleci: test-auth-algorithms Your tests passed on CircleCI!
Details
ci/circleci: test-auth-api Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-bind Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gmysql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gpgsql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-gsqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-ldap Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-lmdb Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-mydns Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-mssql Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-odbc-sqlite3 Your tests passed on CircleCI!
Details
ci/circleci: test-auth-regress-tinydns Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-api Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-bulk Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-regression Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Habbie Habbie deleted the Habbie:gsql-transactions branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.