Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec backport to 4.1.x: Add counters for incoming AD and CD queries #7906

Merged
merged 2 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@omoerbeek
Copy link
Member

commented Jun 11, 2019

(cherry picked from commit 88c33dc)

Short description

Would it be an issue that the snmp objects IDs are no longer contiguous?

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • [X checked that this code was merged to master

@omoerbeek omoerbeek added the rec label Jun 11, 2019

@omoerbeek omoerbeek requested a review from rgacogne Jun 11, 2019

@rgacogne
Copy link
Member

left a comment

LGTM!

@@ -108,6 +108,8 @@ static const oid policyResultNodataOID[] = { RECURSOR_STATS_OID, 89 };
static const oid policyResultTruncateOID[] = { RECURSOR_STATS_OID, 90 };
static const oid policyResultCustomOID[] = { RECURSOR_STATS_OID, 91 };
static const oid queryPipeFullDropsOID[] = { RECURSOR_STATS_OID, 92 };
static const oid dnssecAuthenticDataQueriesOID[] = { RECURSOR_STATS_OID, 95 };

This comment has been minimized.

Copy link
@rgacogne

rgacogne Jun 11, 2019

Member

I was a bit surprised a first by the gap between 92 and 95, but I guess it might make sense to keep the same OIDs between 4.2.x and 4.1.x.

@rgacogne rgacogne added this to the rec-4.1.x milestone Jun 11, 2019

@omoerbeek omoerbeek force-pushed the omoerbeek:backport-7298 branch from 4e44192 to 6f5f15b Jun 11, 2019

@omoerbeek omoerbeek merged commit 9223136 into PowerDNS:rel/rec-4.1.x Jun 11, 2019

0 of 2 checks passed

ci/circleci: Build Error Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@omoerbeek omoerbeek deleted the omoerbeek:backport-7298 branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.