Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Properly override the HTTP Server header for DoH #7911

Merged
merged 1 commit into from Jun 24, 2019

Conversation

rgacogne
Copy link
Member

Short description

h2o doesn't allow us to override the HTTP Server: header in the usual way but we can override the default value in the h2o_globalconf_t object.

Fixes #7894.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jun 12, 2019
@rgacogne rgacogne requested a review from chbruyand June 13, 2019 07:50
@rgacogne rgacogne mentioned this pull request Jun 24, 2019
7 tasks
@rgacogne rgacogne merged commit d0283b3 into PowerDNS:master Jun 24, 2019
@rgacogne rgacogne deleted the dnsdist-doh-server-header branch June 24, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DoH serverTokens: duplicate server header and ignored setting
1 participant