Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: No longer filter DNSSEC metadata when DNSSEC is enabled in gsql #7921

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@Habbie
Copy link
Member

commented Jun 12, 2019

Short description

As noted in #7705, gsql getAllDomainMetadata() did not return all domain
metadata. This function would always filter DNSSEC related metadata, even
if a backend was configured to support DNSSEC.

Backport of #7706

(cherry picked from commit d97e1ae)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
No longer filter DNSSEC metadata when DNSSEC is enabled in gsql
As noted in #7705, gsql getAllDomainMetadata() did not return all domain
metadata.  This function would always filter DNSSEC related metadata, even
if a backend was configured to support DNSSEC.

(cherry picked from commit d97e1ae)

@Habbie Habbie added this to the auth-4.1.x milestone Jun 12, 2019

@zeha

zeha approved these changes Jun 12, 2019

Copy link
Collaborator

left a comment

LGTM

@Habbie Habbie changed the title No longer filter DNSSEC metadata when DNSSEC is enabled in gsql backport: No longer filter DNSSEC metadata when DNSSEC is enabled in gsql Jun 12, 2019

@Habbie Habbie merged commit dc247a5 into PowerDNS:rel/auth-4.1.x Jun 12, 2019

0 of 2 checks passed

ci/circleci: build Your tests failed on CircleCI
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@Habbie Habbie deleted the Habbie:backport-7706 branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.