dnsdist: Proper HTTP response for timeouts over DoH #7927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
force-pushed
the
dnsdist-doh-timeout
branch
from
4602be8 to
2cfc522
Compare
|
Fixed the use-after-free race reported by ASAN on Circle CI. |
In rare cases, the responder thread might get a response _before_ the send() call of the DoH client thread has returned, resulting in ASAN reporting a use-after-free since the response was written into the now useless query object.
rgacogne
force-pushed
the
dnsdist-doh-timeout
branch
from
de82b15 to
246ff31
Compare
|
Rebased now that #7917 has been merged. |
omoerbeek
reviewed
Jul 16, 2019
|
I must say I don't grasp all of dnsdist yet, but this PR look ok (with the one comment on the nullptr case). |
|
Giving up on the LGTM check, it is simply taking too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Timeouts, actively discovered or not, were not properly handled for DoH queries.
This PR is based on top of #7917 so we can send a proper HTTP status code, it will need to be rebased.
Checklist
I have: