Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec backport to 4.2.x: : Compare the CacheKey type and place first then the name #7939

Merged

Conversation

Projects
None yet
2 participants
@omoerbeek
Copy link
Member

commented Jun 17, 2019

We don't care about the actual ordering, so let's do the cheapest
comparisons first then the quite expensive DNSName comparison only
if we really need to.

(cherry picked from commit 186e99c)

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master
rec: Compare the CacheKey type and place first then the name
We don't care about the actual ordering, so let's do the cheapest
comparisons first then the quite expensive DNSName comparison only
if we really need to.

(cherry picked from commit 186e99c)

@omoerbeek omoerbeek requested a review from rgacogne Jun 17, 2019

@omoerbeek

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

Branch created with modified cherry-pick-pr.py

@rgacogne rgacogne added this to the rec-4.2.0 milestone Jun 17, 2019

@omoerbeek omoerbeek changed the title rec: Compare the CacheKey type and place first then the name rec backport to 4.2.x: : Compare the CacheKey type and place first then the name Jun 17, 2019

@omoerbeek omoerbeek merged commit 8f6d510 into PowerDNS:rel/rec-4.2.x Jun 17, 2019

3 of 16 checks passed

ci/circleci: test-auth-algorithms Your tests are queued behind your running builds
Details
ci/circleci: test-auth-api Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-bind Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-gmysql Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-gpgsql Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-gsqlite3 Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-ldap Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-lmdb Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-mydns Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-odbc-mssql Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-odbc-sqlite3 Your tests are queued behind your running builds
Details
ci/circleci: test-auth-regress-tinydns Your tests are queued behind your running builds
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: build-auth Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-api Your tests passed on CircleCI!
Details
ci/circleci: test-recursor-bulk Your tests passed on CircleCI!
Details

@omoerbeek omoerbeek deleted the omoerbeek:backport-7905-to-rec-4.2.x branch Jun 17, 2019

@omoerbeek omoerbeek modified the milestones: rec-4.2.0, rec-4.2.0-rc2 Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.