Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix handling of backend connection failing over TCP #7979

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 25, 2019

Short description

  • The creation of the Socket object can throw if we run out of file descriptors ;
  • Catch exceptions thrown from setupTCPDownstream() earlier, we don't care why it failed later, only that it did.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
- The creation of the Socket object can throw if we run out of file
descriptors ;
- Catch exceptions thrown from setupTCPDownstream() earlier, we don't
care why it failed later, only that it did.
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jun 25, 2019
@rgacogne rgacogne requested a review from Habbie Jun 25, 2019
Habbie
Habbie approved these changes Jun 25, 2019
@rgacogne rgacogne merged commit 290b7cc into PowerDNS:master Jun 27, 2019
23 checks passed
Loading
@rgacogne rgacogne deleted the ddist-tcp-backend-failure branch Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants