Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuffixMatchNode:add: Accept more types #7985

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

pieterlexis
Copy link
Contributor

@pieterlexis pieterlexis commented Jun 25, 2019

Short description

The SuffixMatchNode now also accepts a table of DNSNames, a table of
string, and singular strings.

Closes #7390.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

The SuffixMatchNode now also accepts a table of DNSNames, a table of
string, and singular strings.
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

pdns/dnsdist-lua-bindings.cc Show resolved Hide resolved
pdns/dnsdist-lua-bindings.cc Show resolved Hide resolved
@rgacogne rgacogne merged commit ec642ce into PowerDNS:master Jun 26, 2019
@pieterlexis pieterlexis deleted the dnsdist-smn-from-string branch June 27, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: make SuffixMatchNode::add() accept a string
2 participants