Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly align the buffer used for cmsgs #7990

Merged
merged 6 commits into from Jun 28, 2019

Conversation

@omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Jun 26, 2019

Short description

OpenBSDs man page http://man.openbsd.org/CMSG_DATA recommend explicit alignment of the buffer to hold cmsg data.
This probably does not matter on non-strict alignment architectures, but is good practise.
(Disclaimer: I was one of the devs involved in this change to the man page, see http://cvsweb.openbsd.org/src/share/man/man3/CMSG_DATA.3).

Noticed while studying #7981

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
Copy link
Member

@rgacogne rgacogne left a comment

Looks good!

pdns/pdns_recursor.cc Outdated Show resolved Hide resolved
pdns/calidns.cc Show resolved Hide resolved
@omoerbeek omoerbeek merged commit 7571f5a into PowerDNS:master Jun 28, 2019
0 of 7 checks passed
@omoerbeek omoerbeek deleted the msgbuf-align branch Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants