Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear CMSG_SPACE(sizeof(data)) in cmsghdr to appease valgrind. #7996

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@omoerbeek
Copy link
Member

@omoerbeek omoerbeek commented Jun 28, 2019

Short description

Valgrind complains if we don't clear the padding. It is debatable if that is right...

Tested to fix #7981: without this PR valgrind complains if run with local address 0.0.0.0, with this the complaints are gone.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@ahupowerdns
Copy link
Contributor

@ahupowerdns ahupowerdns commented Jun 28, 2019

looks good!

@omoerbeek omoerbeek merged commit 8547436 into PowerDNS:master Jul 1, 2019
23 checks passed
@omoerbeek omoerbeek deleted the valgrind-memset-cmsg-space branch Jul 1, 2019
@Habbie Habbie mentioned this pull request Jul 1, 2019
29 tasks
Habbie added a commit to Habbie/pdns that referenced this issue Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants