Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Insert the response into the ringbuffer right after sending it #8003

Merged

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 1, 2019

Short description

The current code could have tried to read a new query before coming back to the insertion, resetting the state in the process and leading to recording a wrong backend or worse, to a NULL-pointer dereference if the new query was dropped or self-answered (no backend then).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
rgacogne added 2 commits Jun 29, 2019
The current code could have tried to read a new query before coming
back to the insertion, resetting the state in the process and leading
to recording a wrong backend or worse, to a NULL-pointer dereference
if the new query was dropped or self-answered (no backend then).
@rgacogne rgacogne added this to the dnsdist-1.4.0 milestone Jul 1, 2019
@rgacogne rgacogne requested a review from chbruyand Jul 1, 2019
Copy link
Member

@chbruyand chbruyand left a comment

LGTM.

Loading

@rgacogne rgacogne merged commit 00d252a into PowerDNS:master Jul 2, 2019
23 checks passed
Loading
@rgacogne rgacogne deleted the dnsdist-fix-crash-ringuffer-insertion branch Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants