Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Display TCP/DoT queries and responses in verbose mode, opcode in grepq #8024

Merged
merged 3 commits into from Jul 8, 2019

Conversation

@rgacogne
Copy link
Member

@rgacogne rgacogne commented Jul 4, 2019

Short description

  • We display the queries and responses received over UDP and DoH in verbose mode, but we were not displaying the ones received over TCP or DoT ;
  • Display any non-zero opcode in grepq().

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
@rgacogne rgacogne force-pushed the dnsdist-opcode-tcp-info branch from 4327980 to f3c9f42 Jul 4, 2019
@rgacogne rgacogne requested a review from omoerbeek Jul 4, 2019
Copy link
Member

@omoerbeek omoerbeek left a comment

One nit

pdns/dns.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 665b16d into PowerDNS:master Jul 8, 2019
23 checks passed
@rgacogne rgacogne deleted the dnsdist-opcode-tcp-info branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants